[*] remove fmt.Println from webserver tests#1218
Merged
pashagolub merged 2 commits intocybertec-postgresql:masterfrom Feb 24, 2026
Merged
[*] remove fmt.Println from webserver tests#1218pashagolub merged 2 commits intocybertec-postgresql:masterfrom
fmt.Println from webserver tests#1218pashagolub merged 2 commits intocybertec-postgresql:masterfrom
Conversation
pashagolub
approved these changes
Feb 22, 2026
pashagolub
changed the title
fmt.Println with t.Log in webserver tests
Collaborator
|
Thanks. Please fix the issues |
pashagolub
force-pushed
the
refactor/standardize-logging
branch
from
19ce039 to
8723452
Compare
pashagolub
changed the title
fmt.Println with t.Log in webserver testsfmt.Println from webserver tests
Makeepan-dev
added a commit
to Makeepan-dev/pgwatch
that referenced
this pull request
Feb 25, 2026
…1218) * test: replace fmt.Println with t.Log in webserver tests * fix tests --------- Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While reviewing the test suite, I noticed
fmt.Printlnbeing used ininternal/webserver/server_test.go. This pollutes the standard console output during test runs.This PR replaces those instances with
t.Log(), ensuring that test logs are only printed when a test fails or when the test suite is explicitly run with the verbose flag (-v).Changes Made
fmt.Printlnwitht.Loginserver_test.goto conform to standard Go testing practices and keep CI logs clean.